Update http dependency name #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
update-http-dependency-name
branch
from
060f1a1 to
26b306b
Compare
trask
force-pushed
the
update-http-dependency-name
branch
from
e2b9bbd to
f639b71
Compare
trask
force-pushed
the
update-http-dependency-name
branch
from
f639b71 to
53162ff
Compare
trask
force-pushed
the
update-http-dependency-name
branch
from
53162ff to
ddd5f3f
Compare
heyams
reviewed
Sep 27, 2021
| class UrlParser { | ||
|
|
||
| /** | ||
| * Returns the path portion of the url. | ||
| * | ||
| * <p>Returns {@code null} if the path cannot be extracted from url for any reason. | ||
| */ | ||
| @Nullable | ||
| static String getPathFromUrl(String url) { |
There was a problem hiding this comment.
It looks like URL.getPath() does the same thing? it handles case like ?query and #. Can we convert url string to an URL object and then use getPath directly, and we can get rid of UrlParser?
There was a problem hiding this comment.
constructing URL objects is slow: open-telemetry/opentelemetry-java-instrumentation#3699
There was a problem hiding this comment.
it will be nice to compare the perf side by side. was URLStreamHandler.parseURL slow or the constructor of URL?
inside the constructor it will invoke parseURL from the handler.. I am wondering if the newer version of java has improved it..
kryalama
approved these changes
Sep 28, 2021
heyams
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1890EDIT: no longer as #1890 has been merged tomain